Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add QPS in tidb_dashboard ref:#1209 #1252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add QPS in tidb_dashboard ref:#1209 #1252

wants to merge 2 commits into from
+42 −2

Conversation

qidi1
Copy link

@qidi1 qidi1 commented May 11, 2022

Signed-off-by: qidi1 [email protected]

What problem does this PR solve?

Currently，Keyviz has keys and bytes dimensions. In some situations, it cannot find the hotspot that the CPU is high caused by QPS, the keys and bytes may be 0. For example:

create table t(id int);
insert into table t values (1)(2)....(1000);
// random read out bound，suppose there are many requests.
select * from t where id = 1000 + rand(0,1000)

Issue Number: #1209

What is changed and how does it work?

Return QPS data in PD.

Check List

Tests

  • Manual test

Related changes

Release note

None

Manual test

We ran a small cluster locally. On the cluster, test data was generated using the tiup bench tool. The results are shown in the figure below.
image
image

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This was referenced May 11, 2022
Open
Open
@breezewish
Copy link
Member

This is very cool! Will you also propose the CPU dimension in this PR, or in later PRs?

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #1252 (da923a4) into master (d3df070) will increase coverage by 0.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   31.53%   31.87%   +0.34%     
==========================================
  Files         290      297       +7     
  Lines       17097    17118      +21     
  Branches      683      680       -3     
==========================================
+ Hits         5391     5456      +65     
+ Misses      11475    11431      -44     
  Partials      231      231
Flag Coverage Δ
be_integration_test_latest 9.28% <0.00%> (-0.01%) ⬇️
be_integration_test_v4.0.1 9.26% <0.00%> (-0.06%) ⬇️
be_unit_test 24.11% <ø> (+0.04%) ⬆️
e2e_test 77.16% <ø> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3df070...da923a4. Read the comment docs.

@ti-chi-bot
Copy link
Member

@qidi1: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qidi1 @ti-chi-bot @CLAassistant @breezewish @codecov-commenter